Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Git, GitOps, Container Registries and SSO login token hide from dashboard #2952

Merged
merged 6 commits into from
Mar 7, 2023
Merged

feat: Git, GitOps, Container Registries and SSO login token hide from dashboard #2952

merged 6 commits into from
Mar 7, 2023

Conversation

Ashish-devtron
Copy link
Contributor

@Ashish-devtron Ashish-devtron commented Feb 10, 2023 •
edited
Loading

Description

Git, GitOps and Container Registries token should not visible in UI, eliminate from the fetch apis and handle in update api.

Fixes #2509

How Has This Been Tested?

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@Ashish-devtron Ashish-devtron changed the title feat: Git, GitOps and Container Registries token hide from dashboard feat: Git, GitOps, Container Registries and SSO login token hide from dashboard Feb 13, 2023
vikramdevtron
vikramdevtron previously approved these changes Feb 27, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ashish-devtron Ashish-devtron merged commit 1db6a26 into main Mar 7, 2023
@Ashish-devtron Ashish-devtron deleted the hide-gitops-token branch March 7, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Clusters Token visibility
2 participants
@Ashish-devtron @vikramdevtron