Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to create container registry with deleted name #2963

Merged
merged 10 commits into from
Mar 2, 2023

Conversation

Ashish-devtron
Copy link
Contributor

@Ashish-devtron Ashish-devtron commented Feb 15, 2023

Description

User unable to create Container registries with same name even the name was already deleted
Fixes #2523

How Has This Been Tested?

-[x] Docker reg create api - manually deleted then created with the same name.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


vikramdevtron
vikramdevtron previously approved these changes Feb 17, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
16.5% 16.5% Duplication

@vikramdevtron vikramdevtron merged commit c0a4f18 into main Mar 2, 2023
@vikramdevtron vikramdevtron deleted the container-registry-with-deleted-name branch March 2, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create Container registries with same name even it's already deleted
2 participants