feat: show notes txt for helmapps deployed by helm #2966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adi6859
requested review from
gireesh-naidu,
vikramdevtron and
prakash100198
api/bean/AppView.go
Outdated
| @@ -121,6 +121,7 @@ type AppDetailContainer struct { | |||
| Environments []Environment `json:"otherEnvironment,omitempty"` | |||
| LinkOuts []LinkOuts `json:"linkOuts,omitempty"` | |||
| ResourceTree map[string]interface{} `json:"resourceTree,omitempty"` | |||
| Notes string `json:"notes"` | |||
There was a problem hiding this comment.
add omitempty here, in case if any chart doesn't have notes.
prakash100198
previously approved these changes
Feb 15, 2023
prakash100198
approved these changes
Feb 15, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
gireesh-naidu
approved these changes
Feb 15, 2023
adi6859
changed the title
adi6859
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature: Show NOTES.txt for helm apps deployed through Devtron with helm
Fixes AB2961
How Has This Been Tested?
1.I have test this by creating a image of Devtron(backend) and then I have deployed it to my cluster and
then checked its behaviour by creating a new helm app deployed using helm and it is working fine.
Checklist:
Does this PR introduce a user-facing change?