docs: Some correction in Documentation at install devtron/ configuration / ingress setup #2981
Conversation
| @@ -5,8 +5,8 @@ The configuration allows you to quickly roll back a configuration change if nece | |||
|
|
|||
| There are two ways you can perform configurations while setting up Devtron dashboard: | |||
|
|
|||
| * [Installation Configurations](setup/install/installation-configuration.md) | |||
| * [Override Configurations](setup/install/override-default-devtron-installation-configs.md) | |||
| * [Installation Configurations](https://github.com/devtron-labs/devtron/blob/main/docs/setup/install/installation-configuration.md) | |||
There was a problem hiding this comment.
The link will still be broken as its coming from Github (after merging to main). Can you please add the link from the document itself? It is: https://docs.devtron.ai/configurations-overview/installation-configuration
| * [Installation Configurations](setup/install/installation-configuration.md) | ||
| * [Override Configurations](setup/install/override-default-devtron-installation-configs.md) | ||
| * [Installation Configurations](https://github.com/devtron-labs/devtron/blob/main/docs/setup/install/installation-configuration.md) | ||
| * [Override Configurations](https://github.com/devtron-labs/devtron/blob/main/docs/setup/install/override-default-devtron-installation-configs.md) |
There was a problem hiding this comment.
| You can also setup `ingress` while setting up Devtron dashboard. Refer [here](https://github.com/devtron-labs/devtron/blob/main/docs/setup/install/ingress-setup.md) for ingress setup. |
There was a problem hiding this comment.
Same here also: https://docs.devtron.ai/configurations-overview/ingress-setup
| @@ -14,7 +14,8 @@ You can use [this yaml file](https://github.com/devtron-labs/devtron/blob/main/m | |||
| apiVersion: networking.k8s.io/v1 | |||
| kind: Ingress | |||
| metadata: | |||
| annotations: nginx.ingress.kubernetes.io/app-root: /dashboard | |||
| annotations: | |||
| nginx.ingress.kubernetes.io/app-root: /dashboard | |||
There was a problem hiding this comment.
what is the difference between the previous annotations and the one you corrected?
There was a problem hiding this comment.
the previous one will create error regarding indentation in YAML file.
putting them in same line cause error.
|
Kudos, SonarCloud Quality Gate passed!
|
prakarsh-dt
changed the title
URL at these page are not correctly redirecting to their destination.
https://docs.devtron.ai/configurations-overview
Intention of yaml file
metadata:
annotations: nginx.ingress.kubernetes.io/app-root: /dashboard
Description
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?