Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:git material source type editable #3015

Merged
merged 9 commits into from
Mar 24, 2023
Merged

Conversation

Aravind-2023
Copy link
Contributor

Description

In the Existing Build pipelines ,the source type is not editable ,I made it editable(i.e that means we can change the branch type from fixed to regex and vice versa).

Fixes AB164

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

1.I have tested the code and some test cases using local host.
2.I have made different CI pipelines and tested using them and also checked the updation in Build and deploy part.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@Aravind-2023 Aravind-2023 requested a review from iamayushm March 22, 2023 08:15
// r.IsRegex = true
//} else {
// r.IsRegex = false
//}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented code.

iamayushm
iamayushm previously approved these changes Mar 22, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Aravind-2023 Aravind-2023 merged commit 9023af8 into main Mar 24, 2023
@Aravind-2023 Aravind-2023 deleted the ci-material-source-editable branch March 24, 2023 07:59
@Aravind-2023 Aravind-2023 restored the ci-material-source-editable branch March 24, 2023 12:40
Aravind-2023 added a commit that referenced this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants