-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:git material source type editable #3015
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamayushm
reviewed
Mar 22, 2023
// r.IsRegex = true | ||
//} else { | ||
// r.IsRegex = false | ||
//} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented code.
iamayushm
previously approved these changes
Mar 22, 2023
SonarCloud Quality Gate failed.
|
iamayushm
approved these changes
Mar 24, 2023
Aravind-2023
added a commit
that referenced
this pull request
Mar 24, 2023
This reverts commit 9023af8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the Existing Build pipelines ,the source type is not editable ,I made it editable(i.e that means we can change the branch type from fixed to regex and vice versa).
Fixes AB164
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
1.I have tested the code and some test cases using local host.
2.I have made different CI pipelines and tested using them and also checked the updation in Build and deploy part.
Checklist:
Does this PR introduce a user-facing change?