Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added description field for environment #3020

Merged
merged 19 commits into from
Apr 13, 2023
Merged

feat: added description field for environment #3020

merged 19 commits into from
Apr 13, 2023

Conversation

mayank-devtron
Copy link
Contributor

@mayank-devtron mayank-devtron commented Feb 21, 2023 •
edited
Loading

Description

This feature add a Description field for environment
Fixes #3005

UI before
Screenshot 2023-02-23 at 12 01 56 PM

Proposed UI
Screenshot 2023-02-23 at 12 03 53 PM

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
test-cases

  • Manual api testing using postman
  • Test case B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
14.3% 14.3% Duplication

prakash100198
prakash100198 previously approved these changes Feb 27, 2023
View reviewed changes
iamayushm
iamayushm previously approved these changes Apr 3, 2023
View reviewed changes
iamayushm
iamayushm previously approved these changes Apr 6, 2023
View reviewed changes
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.3% 8.3% Duplication

@mayank-devtron mayank-devtron merged commit d8f2a5d into main Apr 13, 2023
@mayank-devtron mayank-devtron deleted the provide_short_description_for_environment_name branch April 13, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamayushm iamayushm iamayushm approved these changes

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@prakash100198 prakash100198 prakash100198 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@mayank-devtron @iamayushm @prakash100198 @vikramdevtron