Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade common-lib dependency #3052

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

vishal-dt
Copy link
Contributor

@vishal-dt vishal-dt commented Feb 28, 2023

Description

Upgrade common-lib dependency
New environment variable introduced:

  • NATS_CONSUMER_CONFIG with default value of {\"ackWaitInSecs\":3600}

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Tested on demo cluster and confirmed NATs related configuration changes

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vishal-dt vishal-dt requested a review from vikramdevtron March 2, 2023 06:10
@vikramdevtron vikramdevtron merged commit b8502f2 into main Mar 9, 2023
@vikramdevtron vikramdevtron deleted the feat-update-common-lib-version branch March 9, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants