fix: helm app deployment failure #3060

vishal-dt · 2023-03-01T08:31:25Z

Description

If the helm install fails during CD, re-triggering the CD gives error as
cannot re-use a name that is still in use

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Steps to reproduce the issue is mentioned in above issue.
Steps followed to test the solution:

Create a CD pipeline (with Helm deployment and Manual mode)
Allow Environment Override
Modify Ports in Deployment Template in Environment Overrides

ContainerPort:
  - envoyPort: 0
    idleTimeout: 1800s
    name: app
    port: 0
    servicePort: 0
    supportStreaming: false
    useHTTP2: false

Trigger CD pipeline
1st Failure will have a message related to invalid yaml values
Re-trigger CD pipeline, it will show same error message about invalid yaml values

8. Delete the Environment Overrides 9. Re-trigger the CD pipeline and the deployment should be successful

Checklist:

The title of the PR states what changed and the related issues number (used for the release note).
Does this PR requires documentation updates?
I've updated documentation as required by this PR.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have tested it for all user roles.
I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

NO

anupdhiran

Have provided comments to him offline about PR body and logger comment. Rest looks ok.

vikramdevtron · 2023-03-01T13:02:46Z

pkg/app/AppService.go

@@ -2176,17 +2176,27 @@ func (impl *AppServiceImpl) createHelmAppForCdPipeline(overrideRequest *bean.Val
 				ReleaseIdentifier: releaseIdentifier,
 			}
 			helmResponse, err := impl.helmAppClient.InstallReleaseWithCustomChart(ctx, helmInstallRequest)
+
+			//IMP: update cd pipeline to mark deployment app created, even if helm install fails
