Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: urls pipeline fetching bug fix #3063

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Conversation

gireesh-naidu
Copy link
Member

@gireesh-naidu gireesh-naidu commented Mar 1, 2023

Description

fetching urls throwing bad request error

Fixes #3066

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@gireesh-naidu gireesh-naidu changed the title urls pipeline fetching bug fix fix: urls pipeline fetching bug fix Mar 1, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@iamayushm iamayushm merged commit 293d365 into main Mar 1, 2023
@iamayushm iamayushm deleted the urls_pipeline_fetch_bug_fix branch March 1, 2023 15:23
@gireesh-naidu
Copy link
Member Author

RCA: happened due to fetching pipelines from db for devtron apps and not setting appId before this fetch call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: fetch host urls throwing bad request all the time.
2 participants