Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: branch name field added in API response for a cd Artifact material #3064

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

prakash100198
Copy link
Contributor

@prakash100198 prakash100198 commented Mar 1, 2023

Description

For each particular artifact card shown in Select Image and Rollback section, now we are going to show form which git branch and repo the artifact was prepared.
Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested by deploying on demo, test cases:-
  1. Make a workflow with cd configured, now click on Select Image/ Rollback the api response, previously the branch name was not coming from the backend, but after the fix the branch name is also coming, for a particular cd-pipeline.
  2. tested by looking into api response of diff cd-workflows configured from diff branches, the branch data was coming as correct.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prakash100198 prakash100198 merged commit 6c4879c into main Mar 3, 2023
@prakash100198 prakash100198 deleted the show-branch-in-cd-artifact branch March 3, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants