Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jobs feature #3074

Merged
merged 131 commits into from
Mar 20, 2023
Merged

feat: jobs feature #3074

merged 131 commits into from
Mar 20, 2023

Conversation

ShashwatDadhich
Copy link
Contributor

@ShashwatDadhich ShashwatDadhich commented Mar 3, 2023

Description

Fixes: #3122

Currently, there are two categories of apps in Devtron - Devtron apps and Helm apps. So with the feature proposed in this document, the goal is to add a new category of app called Jobs. The Goal is to add the following features to jobs.
Allow users to create jobs.
Have the following things to create a job.
Configuration -
- Allows the user to add a source code.
- Allows the user to create Job pipelines.
Trigger job -

  • Allow the user to start the build of a job pipeline.
    - Run history
    - Show the logs, source code and artifacts of all the builds.
    - Jobs
    - Shows the list of all the previously created jobs.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

It has been tested locally as well as in a VM

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

ShashwatDevtron and others added 30 commits February 11, 2023 21:44
* fix: Installed apps rbac optimisation (#2918)

* rbac enforced in batch

* minor restructuring

* minor fix

* code comments added

* throwing unauthorised error

* fix: pvc mounted on pods for cache handling  (#2912)

* first cut pvc for ci

* isPvcMounted flag introduced

* cache invalidate and global invalidate handling

* cache path made configurable

* pvc mounted false

* PVC mounted at two new paths for storing build and buildx cache

* mnor fix

* removed redundant objects from struct

* chenged names of env variables for paths

* buildx cache path restored after doing POC

---------

Co-authored-by: Prashant Ghildiyal <prashant@devtron.ai>
Co-authored-by: Kripansh <kripansh@devtron.ai>

* updated log type for pipeline status methods (#2926)

* docs: minor updates ingress (#2931)

* minor updates ingress

* minor updates ingress

* finished on time update fix (#2932)

Co-authored-by: Kripansh <kripansh@devtron.ai>

* fix delete pipeline app status check (#2939)

* feat: added option to propagate custom tag to k8s resources for that application (#2841)

* wip

* sql file renamed

* propagation in labels support for create app api

* validating labels if propagate is true

* refactoring

* sql file no. changed

* removed required field from bool

* sql file no. changed

* removed cascade

* alter app lable key

* db migration seq fix for global tags

---------

Co-authored-by: vikramdevtron <vikram@devtron.ai>

* excluding inactive ci-pipelin-material from pre-cd stage (#2920)

* feat: cluster bearer token hide from dashboard (#2894)

* cluster token config removed mandatory

* api spec added for cluster update and create, and cluster list api changes for token

* fix check config for cluster token

* docs: mount pvc (#2941)

* added pvc

* added pvc

* added pvc

* added pvc

* added pvc

* feat: Resource browser child ref (#2913)

* child rbac handling init commit

* resource manifest validate handling added

* handle rbac case

* wire gen fix

* gvk passed and ap resource handling

* code cleaning

* dead code cleaning

* removed unused func

* fix: k8s log stream cpu issue (#2929)

* updated buffer size

* refactored code for getting logs from k8s

* updated Dockerfile

* updated Dockerfile

* downgraded go version

* removed redundant log

* sorting_changes (#2935)

* support given for cloning linked ci pipelines via workflow cloning API (#2944)

* docs: Added preset plugins (#2904)

* added preset plugins

* added preset plugins

* Added semgrep, codacy

* updates

* updated screenshots

* updates

---------

Co-authored-by: Gireesh Naidu <111440205+gireesh-devtron@users.noreply.github.com>
Co-authored-by: Prakash Kumar <prakash.kumar@devtron.ai>
Co-authored-by: Prashant Ghildiyal <prashant@devtron.ai>
Co-authored-by: Kripansh <kripansh@devtron.ai>
Co-authored-by: kartik-579 <84493919+kartik-579@users.noreply.github.com>
Co-authored-by: SNe789 <113748500+SNe789@users.noreply.github.com>
Co-authored-by: Vikram <73224103+vikramdevtron@users.noreply.github.com>
Co-authored-by: Manish Agrawal <85211469+manish-agrawal-ai@users.noreply.github.com>
Co-authored-by: vikramdevtron <vikram@devtron.ai>
Co-authored-by: kripanshdevtron <107392309+kripanshdevtron@users.noreply.github.com>
Co-authored-by: Dhananjay Sharma <124036328+dhananjay0601@users.noreply.github.com>
@gireesh-naidu gireesh-naidu linked an issue Mar 16, 2023 that may be closed by this pull request
2 tasks
@ShashwatDadhich ShashwatDadhich changed the title Job feature branch feat: job feature branch Mar 16, 2023
@ShashwatDadhich ShashwatDadhich changed the title feat: job feature branch feat: job feature Mar 16, 2023
@ShashwatDadhich ShashwatDadhich changed the title feat: job feature feat: jobs feature Mar 16, 2023
@ShashwatDadhich ShashwatDadhich marked this pull request as ready for review March 16, 2023 13:10
gireesh-naidu
gireesh-naidu previously approved these changes Mar 17, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 19 Code Smells

No Coverage information No Coverage information
3.1% 3.1% Duplication

@ShashwatDadhich ShashwatDadhich merged commit 6390d84 into main Mar 20, 2023
@ShashwatDadhich ShashwatDadhich deleted the job-feature-branch branch March 20, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Jobs Feature
4 participants