Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add timer/counter telemetry for CI process #3081

Merged
merged 29 commits into from
Mar 9, 2023

Conversation

Ashish-devtron
Copy link
Contributor

Description

Show the timer/counter metrics for kube-link api using Prometheus.

Fixes #https://dev.azure.com/DevtronLabs/Devtron/_workitems/edit/2216
Github issue: ##3022

How Has This Been Tested?

  • Tested locally by hitting requests.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

util/helper.go Outdated
@@ -45,6 +45,21 @@ type CDMetrics struct {
Time float64
}

type CIMetrics struct {
CacheDownDuration float64 `json:"CacheDownDuration"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use proper camelCase here

util/helper.go Outdated
CacheUpDuration float64 `json:"CacheUpDuration"`
TotalDuration float64 `json:"TotalDuration"`
CacheDownStartTime time.Time `json:"CacheDownStartTime"`
PreCiStartTime time.Time `json:"pre_ci_start"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ashish-devtron Ashish-devtron merged commit efba10a into main Mar 9, 2023
@Ashish-devtron Ashish-devtron deleted the add-timer-telemetry-for-ci-operation branch March 9, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants