Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: json unmarshal panic error temperory fix. #3095

Merged
merged 6 commits into from
Mar 15, 2023
Merged

fix: json unmarshal panic error temperory fix. #3095

merged 6 commits into from
Mar 15, 2023

Conversation

gireesh-naidu
Copy link
Member

@gireesh-naidu gireesh-naidu commented Mar 9, 2023 •
edited
Loading

Description

json Unmarshall panic error fix

Fixes #3111

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@gireesh-naidu gireesh-naidu changed the title making copy of bytes array to pass it to json unmarshal fix: json unmarshal panic error temperory fix. Mar 9, 2023
kartik-579
kartik-579 previously approved these changes Mar 9, 2023
View reviewed changes
kartik-579
kartik-579 previously approved these changes Mar 13, 2023
View reviewed changes
@gireesh-naidu gireesh-naidu removed the request for review from kripanshdevtron March 13, 2023 10:36
@gireesh-naidu gireesh-naidu changed the title fix: json unmarshal panic error temperory fix. Fix: json unmarshal panic error temperory fix. Mar 14, 2023
@gireesh-naidu gireesh-naidu changed the title Fix: json unmarshal panic error temperory fix. fix: json unmarshal panic error temperory fix. Mar 14, 2023
@gireesh-naidu gireesh-naidu requested a review from nishant-d March 15, 2023 07:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gireesh-naidu gireesh-naidu merged commit 524985a into main Mar 15, 2023
@gireesh-naidu gireesh-naidu deleted the json_unmarshall_temp_fix branch March 15, 2023 07:56
kartik-579 pushed a commit that referenced this pull request Mar 28, 2023
@gireesh-naidu
Merge pull request #49 from gireesh-devtron/oss-main
f69aa7e 
fix: json unmarshal panic error temperory fix. (#3095)
kartik-579 pushed a commit that referenced this pull request Mar 28, 2023
@gireesh-naidu @Shivam-nagar23
fix: json unmarshal panic error temperory fix. (#3095)
6e126aa 
* making copy of bytes array to pass it to json unmarshal

* getting objects from db by value

* changing json raw message to string type

* revert copy of bytes since Data string is passed by value

* test commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishant-d nishant-d nishant-d approved these changes

@kartik-579 kartik-579 kartik-579 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: json unmarshal panic error
3 participants
@gireesh-naidu @nishant-d @kartik-579