fix: Send webhook data(source value and source type) in pipeline api response #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
| Id int `json:"id"` | ||
| Image string `json:"image,notnull"` | ||
| ImageDigest string `json:"image_digest,notnull"` | ||
| MaterialInfo json.RawMessage `json:"material_info"` //git material metadata json array string |
There was a problem hiding this comment.
is this work correctly, we can use map
There was a problem hiding this comment.
it's working fine, also it's previous code
vikramdevtron
approved these changes
Mar 16, 2023
vikramdevtron
approved these changes
Mar 16, 2023
| @@ -182,6 +182,7 @@ type PipelineBuilderImpl struct { | |||
| helmAppService client.HelmAppService | |||
| deploymentGroupRepository repository.DeploymentGroupRepository | |||
| ciPipelineMaterialRepository pipelineConfig.CiPipelineMaterialRepository | |||
| ciWorkflowRepository pipelineConfig.CiWorkflowRepository | |||
| //ciTemplateOverrideRepository pipelineConfig.CiTemplateOverrideRepository | |||
There was a problem hiding this comment.
remove this commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For each particular artifact card shown in Select Image and Rollback section, now we are going to show form which git branch and repo the artifact was prepared.
Fixes #AD2220
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?