Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci artifacts not coming for linked CI pipeline #3134

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

iamayushm
Copy link
Contributor

@iamayushm iamayushm commented Mar 20, 2023

Description

This PR fixes bad gateway error when "select image" is clicked in CD pipeline.
Fixes #3135

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • By checking that whether CI artifacts are coming for linked pipeline or not.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@iamayushm iamayushm changed the title fix: ci artifacts not coming fix: ci artifacts not coming for linked CI pipeline Mar 20, 2023
@iamayushm iamayushm merged commit 26951ac into main Mar 20, 2023
@iamayushm iamayushm deleted the fix_select_image_not_working branch March 20, 2023 09:17
@iamayushm
Copy link
Contributor Author

RCA: Error was because of nil pointer reference. In order to show repo + branch along with each commit in artifact card, we were fetching ci workflow corresponding to that artifact by using workflow id present in ci artifact table. For linked CI pipeline, workflow Id is not present in CI artifact table.So, while fetching workflow details, code was panicking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: CI artifacts not coming for linked CI pipeline
3 participants