Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Manifest output throws error when charts require special KubeVersion #3162

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

adi6859
Copy link
Contributor

@adi6859 adi6859 commented Mar 21, 2023

Description

This PR aims to fix the manifest generation error (as shown below) when charts require special KubeVersion.

Screenshot 2023-03-22 at 7 08 06 PM

Fixes AB2509

How Has This Been Tested?

  1. I have done testing this via image deployment on vm.
  2. I have checked for all possible test cases.
    Test cases are:-
    a.deployed helm chart when no apps is present.
    b. deployed same helm chart again when above app is present.
    c.deployed helm chart via gitOps.
    d.deployed helm chart via helm.
  3. I have also done testing by applying multiple breakpoint for checking data is coming or not.
  4. i have also checked via main.go file by calling my function.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

@adi6859 adi6859 requested a review from vikramdevtron March 21, 2023 15:17
vikramdevtron
vikramdevtron previously approved these changes Mar 22, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vikramdevtron vikramdevtron merged commit c50f1aa into main Mar 22, 2023
@vikramdevtron vikramdevtron deleted the argocd-manifest branch March 22, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants