Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Gitops validate and update with empty token #3168

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

Ashish-devtron
Copy link
Contributor

@Ashish-devtron Ashish-devtron commented Mar 22, 2023

Description

We should update the token from database if token is empty during update request and during validation.

Fixes #https://dev.azure.com/DevtronLabs/Devtron/_workitems/edit/2518

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Tested the code by deploying on cluster

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
100.0% 100.0% Duplication

@Ashish-devtron Ashish-devtron merged commit 5045274 into main Mar 22, 2023
@Ashish-devtron Ashish-devtron deleted the gitops-validate-and-update branch March 22, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants