feat:store notes.txt in db and fetch from db #3183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adi6859
changed the title
| @@ -411,31 +411,26 @@ func (handler *InstalledAppRestHandlerImpl) FetchNotesForArgoInstalledApp(w http | |||
| return | |||
| } | |||
| handler.Logger.Infow("request payload, FetchNotesForArgoInstalledApp, app store", "installedAppId", installedAppId, "envId", envId) | |||
|
|
|||
| notes, appName, err := handler.installedAppService.FindNotesForArgoApplication(installedAppId, envId) | |||
| notes, err := handler.installedAppService.FetchNotesFromdb(installedAppId, envId, token, handler.checkNotesAuth) | |||
There was a problem hiding this comment.
change the function name, fetchChartNotes
| @@ -189,6 +190,13 @@ func (impl InstalledAppRepositoryImpl) UpdateInstalledAppVersion(model *Installe | |||
| } | |||
| return model, nil | |||
| } | |||
| func (impl InstalledAppRepositoryImpl) FetchNotesFromdb(installedAppId int) (*InstalledApps, error) { | |||
| @@ -280,6 +281,33 @@ func (impl AppStoreDeploymentServiceImpl) GetGitOpsRepoName(appName string) stri | |||
| return repoName | |||
| } | |||
|
|
|||
| func (impl AppStoreDeploymentServiceImpl) AppStoreDeployOperationNotesUpdate(installAppId int, notes string) (bool, error) { | |||
There was a problem hiding this comment.
UpdateNotesForInstalledApp
| return "", nil | ||
| } | ||
|
|
||
| if installedApp.Notes == "" { |
| isValidAuth := checkNotesAuth(token, appName, envId) | ||
| if !isValidAuth { | ||
| impl.logger.Errorw("unauthorized user", "isValidAuth", isValidAuth) | ||
| return "", nil |
iamayushm
reviewed
Mar 27, 2023
| impl.logger.Errorw("error fetching installed app version in installed app service", "err", err) | ||
| return "", err | ||
| } | ||
| appStoreAppVersion, err := impl.appStoreApplicationVersionRepository.FindById(installedAppVerison.AppStoreApplicationVersion.Id) |
There was a problem hiding this comment.
we are already getting appStoreAppVersion by installedAppVerison, err := impl.installedAppRepository.GetInstalledAppVersionByInstalledAppIdAndEnvId(installedAppId, envId) , no need to fetch it again.
iamayushm
previously approved these changes
Mar 27, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
iamayushm
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR I have to store notes.txt in db for helm charts deployed via gitOps and fetch from db if present .
Fixes Ab2484
How Has This Been Tested?
a. when notes is not present in db.
b. when notes is present in db.
c.for all these test test cases , I have checked for timing and it is working fine , if fetching from db it is taking less time and when fetching from kubelink it is taking more time.
3.I have also done testing by putting multiple breakpoints.
Checklist: