Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - handled nil pointer access, fixed not null constraint for git material deletion #3199

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Mar 28, 2023

Description

Handled nil pointer access for pipeline deletion, added updation with not null for ci pipeline materials update method.

Fixes #3198

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Local Environment
  • QA Environment

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kartik-579 kartik-579 merged commit 22d3c1a into main Mar 28, 2023
@kartik-579 kartik-579 deleted the ci-pipeline-fix branch March 28, 2023 10:07
gireesh-naidu pushed a commit that referenced this pull request Jun 16, 2023
* release: PR for v0.6.14 (#3194)

* Updated release-notes files

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* Updated release notes

* chore: Security Context for pods and container in chart/devtron and manifest/yaml (#3193)

* Added changes for securityContext

* change position of global

* Update devtron-bom.yaml

---------

Co-authored-by: jatin jangir <79351203+jatin-jangir@users.noreply.github.com>

* Updated latest image of ci-runner in installer

* Updated latest image of git-sensor in installer

* Updated latest image of kubewatch in installer

* Updated latest image of lens in installer

* Updated latest image of git-sensor in installer

* Updated latest image of lens in installer

* Updated latest image of image-scanner in installer

* Updated latest image of kubelink in installer

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated latest image of authenticator in installer

* Updated latest image of dashboard in installer

* Removed securityContext from casbin initContainer

* Updated latest image of inception in installer

* Update Chart.yaml

* Update devtron-bom.yaml

* Update devtron-installer.yaml

* Update installation-script

* Updated latest image of chart-sync in installer

* Updated latest image of migrator in installer

* Update migrator.yaml

* Update values.yaml

* Update devtron-bom.yaml

* Updated securityContext in initContainer of casbin

* Update migrator.yaml

* Updated release-notes files

* Fixed security context for inception

* Added initcontainer to chown permissions

* Updated release-notes files

* Update release-notes-v0.6.14.md

* Update releasenotes.md

* enable application groups

---------

Co-authored-by: jatin-jangir-0220 <122791251+jatin-jangir-0220@users.noreply.github.com>
Co-authored-by: jatin jangir <79351203+jatin-jangir@users.noreply.github.com>
Co-authored-by: pawan-mehta-dt <117346502+pawan-mehta-dt@users.noreply.github.com>

* fix  - handled nil pointer access, fixed not null constraint for material deletion (#3199)

---------

Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com>
Co-authored-by: jatin-jangir-0220 <122791251+jatin-jangir-0220@users.noreply.github.com>
Co-authored-by: jatin jangir <79351203+jatin-jangir@users.noreply.github.com>
Co-authored-by: pawan-mehta-dt <117346502+pawan-mehta-dt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Getting bad gateway during deleting CI pipeline
2 participants