Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: helm pipeline force delete check update #3245

Merged
merged 1 commit into from
Apr 6, 2023
Merged

fix: helm pipeline force delete check update #3245

merged 1 commit into from
Apr 6, 2023

Conversation

kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Apr 6, 2023 •
edited
Loading

Description

Added force deletion check in case of error when deleting helm deployed cd pipeline.

Fixes #3244

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kartik-579 kartik-579 merged commit 924cc21 into main Apr 6, 2023
@kartik-579 kartik-579 deleted the helm-pipeline-delete-fix branch April 6, 2023 08:10
gireesh-naidu pushed a commit that referenced this pull request Jun 16, 2023
@kartik-579
Oss sync (#117)
54cf5f5 
* fix: git sensor initContainer indentation fix (#3229)
* Update gitsensor.yaml
* Update gitsensor.yaml
* fix helm pipeline delete bug (#3245)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Not able to delete cd pipeline if not deployed
2 participants
@kartik-579 @kripanshdevtron