Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pipeline strategy empty check #3256

Merged
merged 2 commits into from
Apr 7, 2023
Merged

fix: Pipeline strategy empty check #3256

merged 2 commits into from
Apr 7, 2023

Conversation

kripanshdevtron
Copy link
Contributor

@kripanshdevtron kripanshdevtron commented Apr 7, 2023 •
edited
Loading

Description

pipeline strategy is not created for CronJob and Job Apps, added empty check.

Fixes #3247

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kripanshdevtron kripanshdevtron changed the title Pipeline strategy empty check fix: Pipeline strategy empty check Apr 7, 2023
@kripanshdevtron kripanshdevtron merged commit c52d00c into main Apr 7, 2023
@kripanshdevtron kripanshdevtron deleted the pipeline-strategy-empty-check branch April 7, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartik-579 kartik-579 kartik-579 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Config diff breaks for Job & Cronjob chart
2 participants
@kripanshdevtron @kartik-579