feat: private chart support for helm apps #3267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pkg/chartRepo/ChartRepositoryService.go # pkg/chartRepo/bean.go # pkg/chartRepo/repository/ChartRepoRepository.go # wire_gen.go
vikramdevtron
approved these changes
Apr 13, 2023
vikramdevtron
previously approved these changes
Apr 14, 2023
vikramdevtron
previously approved these changes
Apr 19, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
vikramdevtron
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Option for adding private helm charts from devtron UI. Support is provided for both gitOps and Helm installation.
Fixes #1906
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
This PR has been tested against these test cases:-
https://docs.google.com/document/d/1NPrGgGih5lqOzTN32Fpnw_SgGewDo_fCYlsQ8g49Y4Q/edit
Checklist:
Does this PR introduce a user-facing change?