Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom app grouping #3295

Merged
merged 28 commits into from
Apr 20, 2023
Merged

Custom app grouping #3295

merged 28 commits into from
Apr 20, 2023

Conversation

vikramdevtron
Copy link
Contributor

@vikramdevtron vikramdevtron commented Apr 18, 2023

Description

In app grouping, there are multiple apps rendering for one environment, sometimes users just want some group of apps only. He can do this now but can’t save that filter.

Users can create filters for specific environments, multiple filters can be added within an environment. Filters are app groups (one or more than one app’s).

Tech Doc and Test Scenarios
https://docs.google.com/document/d/1URKOxV_cKld3WG99GEKKMsS0WbvbRzkQexVcP5nQbf8/edit

Fixes #https://dev.azure.com/DevtronLabs/Devtron/_workitems/edit/2698

How Has This Been Tested?

  • Tested scenarios

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@vikramdevtron vikramdevtron self-assigned this Apr 18, 2023
iamayushm
iamayushm previously approved these changes Apr 19, 2023
iamayushm
iamayushm previously approved these changes Apr 19, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 25 Code Smells

No Coverage information No Coverage information
26.6% 26.6% Duplication

@vikramdevtron vikramdevtron requested a review from iamayushm April 20, 2023 08:20
@vikramdevtron vikramdevtron merged commit a77f3fd into main Apr 20, 2023
@vikramdevtron vikramdevtron deleted the custom-app-grouping branch April 20, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants