feat: show deployment status and timeline for helm apps deployed via gitops #3299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oyment status for an app with resource tree call
…ded for app store applications
…e status called when fetching resource tree for app store application
| } | ||
| resourceName := handler.enforcerUtil.GetAppRBACNameByAppId(installedAppId) | ||
| token := r.Header.Get("token") | ||
| if ok := handler.enforcer.Enforce(token, casbin.ResourceApplications, casbin.ActionGet, resourceName); !ok { |
There was a problem hiding this comment.
need to check environment enforcer
| var timelines []*PipelineStatusTimeline | ||
| err := impl.dbConnection.Model(&timelines). | ||
| Where("installed_app_version_history_id = ?", installedAppVersionHistoryId). | ||
| Where("status in (?)", pg.In(statuses)).Select() |
There was a problem hiding this comment.
check type of statueses
| @@ -1153,7 +1155,7 @@ func (impl *WorkflowDagExecutorImpl) updatePreviousDeploymentStatus(currentRunne | |||
| UpdatedOn: time.Now(), | |||
| }, | |||
| } | |||
| timelineErr = impl.pipelineStatusTimelineService.SaveTimeline(timeline, nil) | |||
| timelineErr = impl.pipelineStatusTimelineService.SaveTimeline(timeline, nil, false) | |||
vikramdevtron
previously approved these changes
May 2, 2023
…yment is triggered
…red in version history table
…ory table in AppStoreDeploymentService file
…case of updating a chart
|
SonarCloud Quality Gate failed.
|
vikramdevtron
approved these changes
May 8, 2023
prakash100198
deleted the
show-deployment-status-and-timeline-for-helm-apps-via-gitops
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr incorporates the feature for showing deployment status timelines for helm apps that are deployed via gitops. Currently we only show deployment status timeline for devtron apps that are deployed via gitops.
Fixes #2429
How Has This Been Tested?
Checklist:
Does this PR introduce a user-facing change?