Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment pipeline strategies configurable #3311

Merged
merged 6 commits into from
Apr 24, 2023
Merged

Deployment pipeline strategies configurable #3311

merged 6 commits into from
Apr 24, 2023

Conversation

vikramdevtron
Copy link
Contributor

@vikramdevtron vikramdevtron commented Apr 21, 2023

Description

While adding new strategies into the system, that won't reflect on create deployment pipeline, made changes and allow new strategies configurable.

Fixes ##3294

How Has This Been Tested?

  • Fetch strategies for the deployment pipeline
  • Deploy using strategy

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@vikramdevtron vikramdevtron self-assigned this Apr 21, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vikramdevtron vikramdevtron merged commit ca715d8 into main Apr 24, 2023
@vikramdevtron vikramdevtron deleted the issue-3294 branch April 24, 2023 08:59
gireesh-naidu pushed a commit that referenced this pull request Jun 16, 2023
* helm install error, nil pointer fix (#3310)

* cluster and environment url fix (#3284)

Co-authored-by: Shubham9t9 <shubhamkumar47022@gmai.com>

* docs: devtron terminal connection timeout issue on gke cluster (#3260)

* doc for devtron terminal connection timeout issue on gke cluster

* Added serial number

* annotation fix

---------

Co-authored-by: Shubham9t9 <shubhamkumar47022@gmai.com>

* Deployment pipeline strategies configurable (#3311)

* ignore pipeline overrides in strategies in not provided

* pipeline strategies dynamic handling

* deployment strategies fetch issue fix

* added default strategy fix for deployment strategy

---------

Co-authored-by: Prakash <prakash.kumar@devtron.ai>
Co-authored-by: Shubham Kumar <87755583+Shubham9t9@users.noreply.github.com>
Co-authored-by: Shubham9t9 <shubhamkumar47022@gmai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants