Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: optimised ci trigger rbac, updated handling for invalid roles in user creation request #3316

Merged
merged 9 commits into from
May 3, 2023
Merged

perf: optimised ci trigger rbac, updated handling for invalid roles in user creation request #3316

merged 9 commits into from
May 3, 2023

Conversation

kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Apr 25, 2023 •
edited
Loading

Description

Optimised ci trigger rbac enforcement logic. Added handling for invalid role in user creation/updation request.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@kartik-579 kartik-579 changed the title fix: updated handling for invalid roles in user creation request fix: optimised ci trigger rbac, updated handling for invalid roles in user creation request Apr 26, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kartik-579 kartik-579 merged commit 35184a8 into main May 3, 2023
@kartik-579 kartik-579 deleted the user-creation-handling branch May 3, 2023 19:35
@kartik-579 kartik-579 changed the title fix: optimised ci trigger rbac, updated handling for invalid roles in user creation request perf: optimised ci trigger rbac, updated handling for invalid roles in user creation request May 3, 2023
gireesh-naidu pushed a commit that referenced this pull request Jun 16, 2023
@kartik-579
fix: optimised ci trigger rbac, updated handling for invalid roles in…
5c0201e 
… user creation request (#3316) (#176)

* updated handling for invalid roles in user creation request

* updated log

* updated log

* optimised ci pipeline trigger rbac

* removed token from logs

* removed array append for unauthorised cd pipelines in ci trigger api rbac

* updated logs
gireesh-naidu pushed a commit that referenced this pull request Jun 16, 2023
@kartik-579
Oss sync (#177)
267ba77 
* fix: optimised ci trigger rbac, updated handling for invalid roles in user creation request (#3316)

* updated handling for invalid roles in user creation request

* updated log

* updated log

* optimised ci pipeline trigger rbac

* removed token from logs

* removed array append for unauthorised cd pipelines in ci trigger api rbac

* updated logs

* feat: added api for getting list of all default rbac roles (#3344)

* added api for getting list of all default roles

* added router, resthandler, service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kartik-579 @kripanshdevtron