Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added build-context support in ci build #3329

Merged
merged 29 commits into from
May 12, 2023
Merged

feat: added build-context support in ci build #3329

merged 29 commits into from
May 12, 2023

Conversation

gireesh-naidu
Copy link
Member

@gireesh-naidu gireesh-naidu commented May 2, 2023 •
edited by kartik-579
Loading

Description

Fixes #2703 #2070

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@gireesh-naidu gireesh-naidu changed the title Build context feat: Build context May 2, 2023
@gireesh-naidu gireesh-naidu linked an issue May 2, 2023 that may be closed by this pull request
Feature: Build context and extraArgs to support input of any native docker params as an array or a string #3258
Closed
2 tasks
kartik-579
kartik-579 requested changes May 11, 2023
View reviewed changes
kartik-579
kartik-579 previously approved these changes May 11, 2023
View reviewed changes
@gireesh-naidu gireesh-naidu changed the title feat: Build context feat: added build-context support in ci build May 12, 2023
kartik-579
kartik-579 previously approved these changes May 12, 2023
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gireesh-naidu gireesh-naidu merged commit 533a7d4 into main May 12, 2023
@gireesh-naidu gireesh-naidu deleted the build-context branch May 12, 2023 13:46
@gireesh-naidu gireesh-naidu linked an issue May 15, 2023 that may be closed by this pull request
Checkout at path where dockerfile is present #2070
Closed
gireesh-naidu added a commit that referenced this pull request Jun 16, 2023
@gireesh-naidu
Merge pull request #187 from gireesh-devtron/build-context
2255755 
feat: added build-context support in ci build (#3329)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartik-579 kartik-579 kartik-579 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gireesh-naidu @kartik-579