Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: made pipeline status crons cascading #3372

Merged
merged 3 commits into from
May 11, 2023

Conversation

kartik-579
Copy link
Member

@kartik-579 kartik-579 commented May 10, 2023

Description

Made pipeline status update crons skip if old cycle is not completed.

Fixes #3375

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@kartik-579 kartik-579 force-pushed the pipeline-cron-cascade branch from 8fcd6ca to 987b541 Compare May 11, 2023 07:39
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kartik-579 kartik-579 merged commit b906c66 into main May 11, 2023
@kartik-579 kartik-579 deleted the pipeline-cron-cascade branch May 11, 2023 09:48
gireesh-naidu pushed a commit that referenced this pull request Jun 16, 2023
* feat: Approval node scripts (#3345)

* approval node scripts

* go template with missing key handling

* approver param added

* reverted TPrintf func

* approver param type change

* script number updated

* script version update

* script number updated

* enhancement: made revision history limit configurable for helm upgrade (#3353)

* made revision history limit configurable for helm upgrade

* review changes

* updated fieldName

* renamed constS

* added deployment_strategy_ref_mapping_removal (#3362)

* task: changes for kubelink update application requests (#3359)

* changes for kubelink - update application requests

* added bean.go

* fix: updated rbac for fetching all default role (#3363)

* updated rbac for fetching all default role

* moved method to get rbac team names to enforcerUtil

* enhancement: made pipeline status crons cascading (#3372)

* made pipeline status crons cascading, added metrics for cron process duration

* updated defer calls

* updated label for cron status metric

---------

Co-authored-by: kripanshdevtron <107392309+kripanshdevtron@users.noreply.github.com>
Co-authored-by: Pawan Kumar <85476803+pawan-59@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Increase in failed or unhealthy deployments slows down devtron
2 participants