Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deployment triggered time handling for pre deployed apps #3378

Merged
merged 2 commits into from
May 12, 2023

Conversation

prakash100198
Copy link
Contributor

Description

Deployment triggered time was not showing in case of pre-deployed helm apps, thsis pr fixes that issue
Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tested by deploying my changes on demo cluster

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@prakash100198 prakash100198 requested a review from iamayushm May 12, 2023 07:38
iamayushm
iamayushm previously approved these changes May 12, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prakash100198 prakash100198 requested a review from iamayushm May 12, 2023 11:27
@prakash100198 prakash100198 merged commit ec070b5 into main May 12, 2023
@prakash100198 prakash100198 deleted the deployment-status-pre-deployed-apps-handling branch May 12, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants