Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ci pipeline trigger bad gateway #3386

Merged
merged 1 commit into from
May 16, 2023
Merged

fix: ci pipeline trigger bad gateway #3386

merged 1 commit into from
May 16, 2023

Conversation

iamayushm
Copy link
Contributor

@iamayushm iamayushm commented May 16, 2023 •
edited
Loading

Description

Fixes #3387

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@iamayushm iamayushm changed the title fix: adding nil pointer check fix: ci pipeline trigger bad gateway May 16, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@iamayushm iamayushm merged commit 15fbebf into main May 16, 2023
@iamayushm iamayushm deleted the nil-pointer-fix-ci-trigger branch May 16, 2023 10:37
@iamayushm
Copy link
Contributor Author

RCA: this was happening for older apps (apps before build pack story) as for these apps there is no entry in ci_build_config table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireesh-naidu gireesh-naidu gireesh-naidu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: bad gateway on ci pipeline trigger
2 participants
@iamayushm @gireesh-naidu