Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated audit info for cd pipeline delete req #3404

Merged
merged 1 commit into from
May 29, 2023
Merged

fix: updated audit info for cd pipeline delete req #3404

merged 1 commit into from
May 29, 2023

Conversation

kartik-579
Copy link
Member

@kartik-579 kartik-579 commented May 19, 2023 •
edited
Loading

Description

Audit log info for cd pipeline delete requests was not updating the user who did the action. Updated those fields in the db.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kartik-579 kartik-579 merged commit f45916a into main May 29, 2023
@kartik-579 kartik-579 deleted the cd-pipeline-delete-audit-fix branch May 29, 2023 07:33
gireesh-naidu pushed a commit that referenced this pull request Jun 16, 2023
@kartik-579
updated audit info for cd pipeline delete req (#3404) (#220)
be944f5
gireesh-naidu pushed a commit that referenced this pull request Jun 16, 2023
@prakarsh-dt @kartik-579 @jatin-jangir-0220
SYNC: OSS sync for 260f871 (#221)
3bf0f67 
* updated audit info for cd pipeline delete req (#3404)

* feat: Added condition for notifying HPA if Keda is enabled and handle HPA part in KEDA  (#3391)

* added condition for kedaAutoScaleEnabled

* added new notification line

* added nil condition

---------

Co-authored-by: kartik-579 <84493919+kartik-579@users.noreply.github.com>
Co-authored-by: jatin-jangir-0220 <122791251+jatin-jangir-0220@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kartik-579 @kripanshdevtron