Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: installAppVersionRequest id was being set at wrong place #3411

Merged
merged 1 commit into from
May 23, 2023

Conversation

prakash100198
Copy link
Contributor

@prakash100198 prakash100198 commented May 23, 2023

Description

RCA:- This happened due to code refactoring done when updating installed_app_versions and installed_apps table, all the updation previously took place in one function but after refactoring on case must have been missed where installedAppRequestId was being set at wrong place, but this pr fixed that
API affected:- /orchestrator/app-store/deployment/application/update
Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prakash100198 prakash100198 merged commit bc35eb7 into main May 23, 2023
@prakash100198 prakash100198 deleted the bharatpay-chart-id-0-fix branch May 23, 2023 11:37
@kushagra-devtron
Copy link

kushagra-devtron commented May 29, 2023

There are many things unclear in the RCA. @prakash100198 : please add the following points so that we can better understand the root cause and issue.

  • Include the customer impact.
  • Add the github issue/ADO issue link.
  • API affected.
  • In the RCA, we need to more brainstorm to be able understand - how was this case missed, and how we can ensure that such cases are not missed in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants