Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bulk-chart-deploy-fix #3478

Merged
merged 1 commit into from
Jun 6, 2023
Merged

fix: bulk-chart-deploy-fix #3478

merged 1 commit into from
Jun 6, 2023

Conversation

iamayushm
Copy link
Contributor

@iamayushm iamayushm commented Jun 5, 2023

Description

chart group - bulk chart deploy api not working
Fixes #3476
#3477

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@iamayushm
Copy link
Contributor Author

RCA :- for helm apps, in old gitOps function, argoCD app name was being set. After cd refactoring, In new gitOps function argocd app name was not being set, so app creation on argocd was failing.

@iamayushm iamayushm merged commit 47c00ed into main Jun 6, 2023
@iamayushm iamayushm deleted the bulk-chart-deploy-fix branch June 6, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Devtron Service breakdown after deploying any chart
2 participants