fix: disable api update if disabled from UI #3487
Conversation
pkg/pipeline/PipelineBuilder.go
Outdated
| impl.logger.Errorw("exception while getting unique client id", "error", err) | ||
| return nil, err | ||
| } | ||
| cm, err := impl.K8sUtil.GetConfigMap(ConfigMapNamespace, DashboardConfigMap, client) |
| return nil, err | ||
| } | ||
| cm, err := impl.K8sUtil.GetConfigMap(ConfigMapNamespace, DashboardConfigMap, client) | ||
| datamap := cm.Data |
There was a problem hiding this comment.
What if cm is nil, handle that case also
There was a problem hiding this comment.
not able to see it handled
There was a problem hiding this comment.
might not be showing that time, handled it.
pkg/pipeline/PipelineBuilder.go
Outdated
| @@ -68,6 +68,9 @@ import ( | |||
| "go.uber.org/zap" | |||
| ) | |||
|
|
|||
| const DashboardConfigMap = "dashboard-cm" | |||
| const ConfigMapNamespace = "devtroncd" | |||
There was a problem hiding this comment.
check similar constants already used, remove namespace const.
There was a problem hiding this comment.
dashboard-cm const is not used, removed namespace const.
| return nil, err | ||
| } | ||
| cm, err := impl.K8sUtil.GetConfigMap(ConfigMapNamespace, DashboardConfigMap, client) | ||
| datamap := cm.Data |
There was a problem hiding this comment.
not able to see it handled
| @@ -1413,6 +1418,24 @@ func (impl PipelineBuilderImpl) PatchCiPipeline(request *bean.CiPatchRequest) (c | |||
| ciConfig.AppWorkflowId = request.AppWorkflowId | |||
| ciConfig.UserId = request.UserId | |||
| if request.CiPipeline != nil { | |||
| client, err := impl.K8sUtil.GetClientForInCluster() | |||
There was a problem hiding this comment.
will it works only for in cluster ? if not handle by cluster id.
pkg/pipeline/PipelineBuilder.go
Outdated
| return nil, err | ||
| } | ||
| datamap := cm.Data | ||
| forceScanConfig, err := strconv.ParseBool(datamap["FORCE_SECURITY_SCANNING"]) |
There was a problem hiding this comment.
add nil check for datamap and add constant for KEY
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 141558 | Generic High Entropy Secret | 9880939 | scripts/devtron-reference-helm-charts/cronjob-chart_1-5-0/env-values.yaml | View secret |
| 2763127 | Generic High Entropy Secret | 9880939 | scripts/devtron-reference-helm-charts/cronjob-chart_1-5-0/secrets-test-values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
SonarCloud Quality Gate failed.
|
Description
Disable the API Update if the force security scanning is abled from UI.
Fixes #2574
How Has This Been Tested?
Tested all the using cases manually by Postman.
Checklist: