Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Global secret data bug in CI workflow #3504

Merged
merged 5 commits into from
Jun 13, 2023
Merged

fix: Global secret data bug in CI workflow #3504

merged 5 commits into from
Jun 13, 2023

Conversation

subhashish-devtron
Copy link
Contributor

Description

Fixes #

fixes null value of global secret value in CI workflow caused due to unhandled conversion for CI introduced during refactoring of Argo Workflow executor

How Has This Been Tested?

tested through automations tests with the breaking scenario pre and post fix

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prakarsh-dt prakarsh-dt dismissed kripanshdevtron’s stale review June 13, 2023 11:32

The merge-base changed after approval.

prakarsh-dt
prakarsh-dt approved these changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@prakarsh-dt prakarsh-dt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as @kripanshdevtron is unavailable.

@prakarsh-dt prakarsh-dt merged commit 0e97f1a into main Jun 13, 2023
@prakarsh-dt prakarsh-dt deleted the fixCIGlobalSecret branch June 13, 2023 13:20
gireesh-naidu pushed a commit that referenced this pull request Jun 16, 2023
@subhashish-devtron @prakarsh-dt
fix: Global secret data bug in CI workflow (#3504)
e5c410a 
* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* fix Global secret data bug in CI workflow

* Revert "Updated latest image of devtron in installer"

This reverts commit c5f54cc.

* Revert "Updated latest image of hyperion in installer"

This reverts commit fb145a1.

---------

Co-authored-by: ReleaseBot <prakarsh@devtron.ai>
gireesh-naidu pushed a commit that referenced this pull request Jun 16, 2023
@kartik-579 @prakarsh-dt
@pawan-mehta-dt @subhashish-devtron
Oss sync (#247)
3703934 
* release: PR for v0.6.18-rc.1 (#3497)

* Created release-notes files

* Update releasenotes.md

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated latest image of dashboard in installer

* Updated release notes

* Updated release notes

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated release-notes files

* Updated latest image of dashboard in installer

* Updated release-notes files

* Updated latest image of ci-runner in installer

* Update Chart.yaml

* Update values.yaml

* Update devtron-bom.yaml

* Update values.yaml

* Update devtron-installer.yaml

* Update installation-script

* Update releasenotes.md

* Updated release-notes files

* Update releasenotes.md

* Update releasenotes.md

* Updated latest image of dashboard in installer

* Updated latest image of ci-runner in installer

* Update Chart.yaml

* Update devtron-bom.yaml

* Update values.yaml

* Update devtron-installer.yaml

* Update installation-script

* Update releasenotes.md

* Updated release-notes files

---------

Co-authored-by: Pawan Mehta <117346502+pawan-mehta-dt@users.noreply.github.com>

* fix: Global secret data bug in CI workflow (#3504)

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* fix Global secret data bug in CI workflow

* Revert "Updated latest image of devtron in installer"

This reverts commit c5f54cc.

* Revert "Updated latest image of hyperion in installer"

This reverts commit fb145a1.

---------

Co-authored-by: ReleaseBot <prakarsh@devtron.ai>

* task: added global policy db scripts (#3486)

* added db scripts

* updated down script

---------

Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com>
Co-authored-by: Pawan Mehta <117346502+pawan-mehta-dt@users.noreply.github.com>
Co-authored-by: subhashish-devtron <129164905+subhashish-devtron@users.noreply.github.com>
Co-authored-by: ReleaseBot <prakarsh@devtron.ai>
gireesh-naidu pushed a commit that referenced this pull request Jun 16, 2023
@kartik-579 @prakarsh-dt
@pawan-mehta-dt @subhashish-devtron
Oss sync (#253)
c979263 
* release: PR for v0.6.18-rc.1 (#3497)

* Created release-notes files

* Update releasenotes.md

* Updated release notes

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated release notes

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated latest image of dashboard in installer

* Updated release notes

* Updated release notes

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* Updated release-notes files

* Updated latest image of dashboard in installer

* Updated release-notes files

* Updated latest image of ci-runner in installer

* Update Chart.yaml

* Update values.yaml

* Update devtron-bom.yaml

* Update values.yaml

* Update devtron-installer.yaml

* Update installation-script

* Update releasenotes.md

* Updated release-notes files

* Update releasenotes.md

* Update releasenotes.md

* Updated latest image of dashboard in installer

* Updated latest image of ci-runner in installer

* Update Chart.yaml

* Update devtron-bom.yaml

* Update values.yaml

* Update devtron-installer.yaml

* Update installation-script

* Update releasenotes.md

* Updated release-notes files

---------

Co-authored-by: Pawan Mehta <117346502+pawan-mehta-dt@users.noreply.github.com>

* fix: Global secret data bug in CI workflow (#3504)

* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* fix Global secret data bug in CI workflow

* Revert "Updated latest image of devtron in installer"

This reverts commit c5f54cc.

* Revert "Updated latest image of hyperion in installer"

This reverts commit fb145a1.

---------

Co-authored-by: ReleaseBot <prakarsh@devtron.ai>

* task: added global policy db scripts (#3486)

* added db scripts

* updated down script

* fix: app workflow creation api panic and app metrics update issue (#3511)

* fix err passing in response writer

* fix for app workflow app mterics issue

* removed redundant comment

---------

Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com>
Co-authored-by: Pawan Mehta <117346502+pawan-mehta-dt@users.noreply.github.com>
Co-authored-by: subhashish-devtron <129164905+subhashish-devtron@users.noreply.github.com>
Co-authored-by: ReleaseBot <prakarsh@devtron.ai>
adi6859 pushed a commit that referenced this pull request Jun 16, 2023
@subhashish-devtron @prakarsh-dt @adi6859
fix: Global secret data bug in CI workflow (#3504)
98d7f43 
* Updated latest image of hyperion in installer

* Updated latest image of devtron in installer

* fix Global secret data bug in CI workflow

* Revert "Updated latest image of devtron in installer"

This reverts commit c5f54cc.

* Revert "Updated latest image of hyperion in installer"

This reverts commit fb145a1.

---------

Co-authored-by: ReleaseBot <prakarsh@devtron.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakarsh-dt prakarsh-dt prakarsh-dt approved these changes

@kripanshdevtron kripanshdevtron kripanshdevtron left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@subhashish-devtron @prakarsh-dt @kripanshdevtron