New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: HPA support for keda autoscaling and fixes for nameOverrides #3522

Merged

vikramdevtron merged 1 commit into main from hpa-support-keda-and-name-override

Jun 16, 2023

Contributor

vikramdevtron commented Jun 16, 2023

Description

HPA handling for keda and fullnameOverride and nameOverride

Fixes #3445

How Has This Been Tested?

Deploy app with fullnameOverride and nameOverride
Deploy app with kedaAutoscaling

Checklist:

The title of the PR states what changed and the related issues number (used for the release note).
Does this PR requires documentation updates?
I've updated documentation as required by this PR.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have tested it for all user roles.
I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


          hpa support added for keda and fix for nameOverride

cdf51e8

sonarqubecloud bot commented Jun 16, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

iamayushm approved these changes

View reviewed changes

vikramdevtron merged commit cfc412f into main

vikramdevtron deleted the hpa-support-keda-and-name-override branch

June 16, 2023 09:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet