Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added custom webhook support for sending notification #3524

Merged
merged 8 commits into from
Jun 22, 2023

Conversation

adi6859
Copy link
Contributor

@adi6859 adi6859 commented Jun 16, 2023

Description

Right now Devtron only supports sending notifications on SES, SMTP, Slack channel. Users might want to configure a custom webhook with configurable payload. New channel required to configure webhook.

Fixes #AB3456

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
-all test are done locally
-testing is also done by deploying image on vm

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@adi6859 adi6859 requested a review from vikramdevtron June 16, 2023 12:35
vikramdevtron
vikramdevtron previously approved these changes Jun 16, 2023
vikramdevtron
vikramdevtron previously approved these changes Jun 21, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

No Coverage information No Coverage information
25.8% 25.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@adi6859 adi6859 merged commit d28dead into main Jun 22, 2023
@adi6859 adi6859 deleted the feat-webhook-config branch June 22, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Support to send notification on webhook.
2 participants