Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getting force_security_scan value from devtron-cm #3558

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

gireesh-naidu
Copy link
Member

@gireesh-naidu gireesh-naidu commented Jun 23, 2023

Description

Issue: we are fetching dashboard-cm to read a variable,but the name of the variable is not always same.this will cause error if the CM of dashboard is different(not devtron-cm).

Fix: now maintaining the variable in devtron-cm that is being fetched from dashboard-cm ,which will resolve the issue for now. later this variable will be removed from dashboard-cm and communicated to dashboard from orchestrator.
Fixes #3594

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


vikramdevtron
vikramdevtron previously approved these changes Jun 23, 2023
@gireesh-naidu gireesh-naidu marked this pull request as ready for review June 23, 2023 10:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gireesh-naidu gireesh-naidu merged commit b23e86d into main Jun 23, 2023
@gireesh-naidu gireesh-naidu deleted the dashboard-cm-secirity-scan-var-fix branch June 23, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Unable to Update CI Pipeline
2 participants