feat: Integrated OCI registries in global config artifact store. #3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 141558 | Generic High Entropy Secret | 254d28b | scripts/devtron-reference-helm-charts/deployment-chart_4-18-0/env-values.yaml | View secret |
| 2763127 | Generic High Entropy Secret | 254d28b | scripts/devtron-reference-helm-charts/deployment-chart_4-18-0/secrets-test-values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
SonarCloud Quality Gate failed.
|
vikramdevtron
approved these changes
Jul 13, 2023
vikramdevtron
approved these changes
Jul 13, 2023
gireesh-naidu
pushed a commit
that referenced
this pull request
Aug 13, 2023
* fix: Deployment enforcement config save err (#3626) * wip * wip * feat: Integrated OCI registries in global config artifact store. (#3567) * migration virtual cluster v2 * migration column name changed * migration update * refactoring gitops code * OCI registry integration * added validation for container storage type action * refactoring gitops code * migration update * migration update * manifest_push_config dto update * manifest push config dto correction * wip * db object correction * manifest push config get function * cleaning code * added integration test cases for docker_artifact_store * skipped integration test cases for built and modified logs * updated validation condition * updated docker_artifact_store query condition for OCI config relations * moving save timeline call * handled nil pointer issue of existing registry update * cleaning code- removing unused functions * trigger event refactor for unit test case * wip * migration-update * wip * updated wire_gen.go --------- Co-authored-by: ayushmaheshwari <ayush@devtron.ai> * updated plugin list, detail get api (#3627) Co-authored-by: Kartik <kartik@MacBook-Pro.Dlink> --------- Co-authored-by: iamayushm <32041961+iamayushm@users.noreply.github.com> Co-authored-by: Asutosh Das <asutosh2000ad@gmail.com> Co-authored-by: ayushmaheshwari <ayush@devtron.ai> Co-authored-by: Kartik <kartik@MacBook-Pro.Dlink> Co-authored-by: Kartik <kartik@MacBook-Pro-2.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified Registry to support both Container and OCI complaint registries. Added util functions for both and bifurcated the existing apis response based on query params to get either container or chart registries only responses based on use cases.
How Has This Been Tested?
Go to global config page and under Container Registries /OCI Registries
Checklist:
Does this PR introduce a user-facing change?