Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for official argo rollout with Canary #3591

Merged
merged 4 commits into from
Jul 3, 2023
Merged

Conversation

pawan-59
Copy link
Contributor

@pawan-59 pawan-59 commented Jul 3, 2023

Description

Added a new reference chart for rollout which supports the official argo-rollout controller. Using this chart users can do the following operations:-

  1. Create an analysis template using this reference chart (5-0-0) and use it in the rollout configuration.
  2. Can use the canary strategy for rollout deployment

How Has This Been Tested?

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

Added a new reference chart for rollout which supports the official argo-rollout controller

@gitguardian
Copy link

gitguardian bot commented Jul 3, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
141558 Generic High Entropy Secret 6a7d7a3 scripts/devtron-reference-helm-charts/reference-chart_5-0-0/env-values.yaml View secret
2763127 Generic High Entropy Secret 6a7d7a3 scripts/devtron-reference-helm-charts/reference-chart_5-0-0/secrets-test-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prakarsh-dt prakarsh-dt changed the title Support for official argo-controller chart feat: support for official argo-controller chart Jul 3, 2023
@prakarsh-dt prakarsh-dt changed the title feat: support for official argo-controller chart feat: support for official argo rollout with Canary Jul 3, 2023
@pawan-59 pawan-59 merged commit 3dece29 into main Jul 3, 2023
@pawan-59 pawan-59 deleted the ref-chart-5-0-0 branch July 3, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants