Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: obfuscate secret for devtron/helm apps #3602

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

iamayushm
Copy link
Contributor

@iamayushm iamayushm commented Jul 6, 2023

Description

Fixes #3603

How Has This Been Tested?

tested by checking that secret is obfuscated or not

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Ash-exp Ash-exp self-requested a review July 6, 2023 07:20
@iamayushm iamayushm merged commit a0d3dee into main Jul 6, 2023
@iamayushm iamayushm deleted the obfuscat_secret branch July 6, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: secret not getting obfuscated for devtron/helm apps
2 participants