Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clone of app with external-ci #3624

Merged
merged 18 commits into from
Jul 14, 2023
Merged

fix: Clone of app with external-ci #3624

merged 18 commits into from
Jul 14, 2023

Conversation

dhananjay0601
Copy link
Contributor

Description

An app cannot be cloned with the external-ci app. So, now we can create a clone app with an external-ci workflow.

Fixes #3593

How Has This Been Tested?

  • By creating workflow with external-ci and cloning another app with this RefApp Workflow
  • By creating workflow with both non-external-ci and external-ci workflow editor and cloning another app with this RefApp Workflow

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

Yes.

@dhananjay0601 dhananjay0601 requested review from kartik-579 and removed request for iamayushm and kartik-579 July 13, 2023 13:44
@dhananjay0601 dhananjay0601 requested a review from kartik-579 July 14, 2023 12:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dhananjay0601 dhananjay0601 changed the title feat: Clone of app with external-ci fix: Clone of app with external-ci Jul 14, 2023
@dhananjay0601 dhananjay0601 merged commit d8f9ab6 into main Jul 14, 2023
@dhananjay0601 dhananjay0601 deleted the clone-app-workflow branch July 14, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: workflow is not cloned in case of deploy through external source
3 participants