Enhancement: Kubernetes api refactoring #3635
Conversation
pkg/k8s/K8sCommonService.go
Outdated
| Version: &request.K8sRequest.ResourceIdentifier.GroupVersionKind.Version, | ||
| Kind: &request.K8sRequest.ResourceIdentifier.GroupVersionKind.Kind, | ||
| } | ||
| manifestRes, err := impl.helmAppService.GetDesiredManifest(ctx, request.AppIdentifier, resourceIdentifier) |
There was a problem hiding this comment.
why are we using helmservice in k8scommonservice?
There was a problem hiding this comment.
we are checking desired manifest before creating resource which is written in kubelink. Need to think about ways where we can use common methods like this without breaking architecture standards
There was a problem hiding this comment.
It was used in case of external helm app when resource health goes missing, we were fetching desired manifest from kubelink to recreate resource, have refactored it to application service with appropriate name.
|
SonarCloud Quality Gate failed.
|
Description
Kubernetes Api Refactoring
Fixes #3641
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?