Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: optimizing when querying DB to get running Helm deployments #3637

Merged
merged 3 commits into from
Jul 16, 2023
Merged

Fix: optimizing when querying DB to get running Helm deployments #3637

merged 3 commits into from
Jul 16, 2023

Conversation

subhashish-devtron
Copy link
Contributor

Description

Fixes #
To reduce CPU load due to the DB query

  • select only required columns
  • only get pipelines deployed within a fixed number of hours(configured) to ignore old stuck pipelines

How Has This Been Tested?

tested on a local cluster deploying application

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@subhashish-devtron subhashish-devtron merged commit 0f7d2fa into main Jul 16, 2023
@subhashish-devtron subhashish-devtron deleted the fix-helm-getall-query branch July 16, 2023 11:57
gireesh-naidu pushed a commit that referenced this pull request Aug 13, 2023
@subhashish-devtron
Fix: optimizing when querying DB to get running Helm deployments (#3637)
5faaf52 
* fix GetLatestTriggersOfHelmPipelinesStuckInNonTerminalStatuses query

* query fix

* fixed query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@subhashish-devtron @kripanshdevtron