Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto deploy fix for migrated pre/post cd steps where inly one is configured #3677

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

prakash100198
Copy link
Contributor

@prakash100198 prakash100198 commented Jul 25, 2023

Description

When the scripts are migrated to steps form from yaml format, and when there are 2 cds, both set to auto, the 2nd cd is not getting triggered when set to auto and this pr aims to fix that issue.
Fixes #3678

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@subhashish-devtron subhashish-devtron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM please link github link since it was a PROD issue (missed during QA)

@prakash100198 prakash100198 merged commit 554baaa into main Jul 25, 2023
@prakash100198 prakash100198 deleted the plugin-update-minor-fix branch July 25, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants