Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: App grouping admin access #3692

Merged
merged 13 commits into from
Jul 31, 2023
Merged

feat: App grouping admin access #3692

merged 13 commits into from
Jul 31, 2023

Conversation

dhananjay0601
Copy link
Contributor

Description

As of now only super admins can do save selection as filter or modify or delete and existing filter group.
This feature request is raised to extend this capability to admins.

Fixes #3402

How Has This Been Tested?

  • Creating the filters from the apps which have admin access only and editing/deleting that filter
  • Updating the already existing filter groups and trying to edit/delete them.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
32.0% 32.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dhananjay0601 dhananjay0601 merged commit 1dc6a99 into main Jul 31, 2023
@dhananjay0601 dhananjay0601 deleted the app-grouping-admin-access branch July 31, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Admins should be able to save, edit and delete filters in application groups
2 participants