Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow changing chart ref #3706

Merged
merged 8 commits into from
Aug 3, 2023
Merged

feat: Allow changing chart ref #3706

merged 8 commits into from
Aug 3, 2023

Conversation

avdhesh-devtron
Copy link
Contributor

@avdhesh-devtron avdhesh-devtron commented Jul 28, 2023 •
edited by vikramdevtron
Loading

Description

Exposes an API to change the base deployment chartRefId for an application in an environment.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@avdhesh-devtron avdhesh-devtron changed the title Allow changing chart ref feat: Allow changing chart ref Aug 3, 2023
vikramdevtron
vikramdevtron previously approved these changes Aug 3, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
3.3% 3.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@vikramdevtron vikramdevtron merged commit 4be7b3b into main Aug 3, 2023
@vikramdevtron vikramdevtron deleted the allow_changing_chart_ref branch August 3, 2023 10:49
@avdhesh-devtron avdhesh-devtron restored the allow_changing_chart_ref branch August 3, 2023 10:54
@avdhesh-devtron avdhesh-devtron deleted the allow_changing_chart_ref branch August 3, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avdhesh-devtron @vikramdevtron