Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: app status fix for helm apps which are deployed via acd #3746

Merged
merged 9 commits into from
Aug 11, 2023
Merged

fix: app status fix for helm apps which are deployed via acd #3746

merged 9 commits into from
Aug 11, 2023

Conversation

ShashwatDadhich
Copy link
Contributor

@ShashwatDadhich ShashwatDadhich commented Aug 9, 2023 •
edited by kripanshdevtron
Loading

Description

Scale workload status (deployment status and app status) not showing for helm chart which is deployed with argocd

Fixes #3485

How Has This Been Tested?

  • Test Locally
  • Test by deploying it in VM

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

@gireesh-naidu gireesh-naidu changed the title fix: fix for scale workload status not showing for helm chart fix: app status fix for helm apps which deployed via acd Aug 10, 2023
@gireesh-naidu gireesh-naidu changed the title fix: app status fix for helm apps which deployed via acd fix: app status fix for helm apps which are deployed via acd Aug 10, 2023
gireesh-naidu
gireesh-naidu previously approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@gireesh-naidu gireesh-naidu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gireesh-naidu
gireesh-naidu reviewed Aug 10, 2023
View reviewed changes
pkg/appStore/deployment/service/InstalledAppService.go Outdated
@@ -1298,6 +1305,12 @@ func (impl InstalledAppServiceImpl) fetchResourceTreeForACD(rctx context.Context
}
// TODO: using this resp.Status to update in app_status table
resourceTree = util3.InterfaceToMapAdapter(resp)
resourceTree, status := impl.checkHibernate(resourceTree, deploymentAppName, ctx)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change status to isHibernating

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

gireesh-naidu
gireesh-naidu previously approved these changes Aug 10, 2023
View reviewed changes
gireesh-naidu
gireesh-naidu previously approved these changes Aug 11, 2023
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ShashwatDadhich ShashwatDadhich merged commit 16475ba into main Aug 11, 2023
@ShashwatDadhich ShashwatDadhich deleted the helm-app-hibernate-status-fix branch August 11, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

@gireesh-naidu gireesh-naidu gireesh-naidu left review comments

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Scale workload status not showing for helm chart
4 participants
@ShashwatDadhich @kripanshdevtron @gireesh-naidu @prakarsh-dt