Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:migration script issue #3750

Merged
merged 11 commits into from
Aug 10, 2023
Merged

fix:migration script issue #3750

merged 11 commits into from
Aug 10, 2023

Conversation

adi6859
Copy link
Contributor

@adi6859 adi6859 commented Aug 10, 2023 •
edited
Loading

Description

when we try to run migration on event table then it is failing in older version , as foreign key constraints for event_id is not present .
In new version foreign key constraints is present .
Table :
Notification_Template
Notifier_event_log

Fixes #3749

How Has This Been Tested?

Tests are performed locally

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@adi6859 adi6859 requested a review from vikramdevtron August 10, 2023 09:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@prakarsh-dt prakarsh-dt changed the title fix :migration script issue fix: migration script issue Aug 10, 2023
@adi6859 adi6859 changed the title fix: migration script issue fix:migration script issue Aug 10, 2023
@adi6859 adi6859 merged commit d9cd8bf into main Aug 10, 2023
@adi6859 adi6859 deleted the notification-migration-fix branch August 10, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: migration failing in older version
3 participants
@adi6859 @vikramdevtron @prakarsh-dt