Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for extra backendPath in ingress #3793

Merged
merged 17 commits into from
Aug 21, 2023
Merged

feat: added support for extra backendPath in ingress #3793

merged 17 commits into from
Aug 21, 2023

Conversation

badal773
Copy link
Contributor

@badal773 badal773 commented Aug 18, 2023

Fixes #513

In these changes, we added support for additional backend paths in ingress. It's for both ingress and internal ingress.
The user should have to add the yaml inside the backend path.

in values.yaml

additionalBackends: 
    - path: /internal
      pathType: "ImplementationSpecific"
      backend:
        service:
          name: test-service-internal
          port:
            number: 80

in ingress yaml it should be looks like

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: release-name
  namespace: test
spec:
  ingressClassName: nginx-internal
  rules:
    - host: "chart-example2.internal"
      http:
        paths:
          - path: /example2/healthz
            pathType: "ImplementationSpecific"
            backend:
              service:
                name: release-name-statefulset-chart_4-18-0-service
                port:
                  number: 80
          - backend:
              service:
                name: test-service-internal
                port:
                  number: 80
            path: /internal
            pathType: ImplementationSpecific

We add this support to these existing charts.

  • statefulset-chart_4-18-0
  • deployment-chart_4-18-0
  • reference-chart_4-18-0
  • reference-chart_5-0-0

@gitguardian
Copy link

gitguardian bot commented Aug 18, 2023

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 46c262d scripts/devtron-reference-helm-charts/reference-chart_4-17-0/env-values.yaml View secret
- Generic High Entropy Secret 46c262d scripts/devtron-reference-helm-charts/reference-chart_4-17-0/secrets-test-values.yaml View secret
- Generic High Entropy Secret e084b22 scripts/devtron-reference-helm-charts/deployment-chart_4-18-0/env-values.yaml View secret
- Generic High Entropy Secret e084b22 scripts/devtron-reference-helm-charts/deployment-chart_4-18-0/secrets-test-values.yaml View secret
- Generic High Entropy Secret ea8f596 scripts/devtron-reference-helm-charts/reference-chart_4-17-0/env-values.yaml View secret
- Generic High Entropy Secret ea8f596 scripts/devtron-reference-helm-charts/reference-chart_4-17-0/secrets-test-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

prakarsh-dt
prakarsh-dt previously approved these changes Aug 21, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@prakarsh-dt prakarsh-dt merged commit ea7a15d into devtron-labs:main Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: ALB http to https redirection needs additional backend with custom service
3 participants